Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation missing on import csv functionality #554

Open
filipposfwt opened this issue Sep 18, 2024 · 2 comments
Open

Input validation missing on import csv functionality #554

filipposfwt opened this issue Sep 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers GSOC this feature is a potential Google Summer of Code candidate

Comments

@filipposfwt
Copy link

Issue

When importing a new standard, no validation is performed on the imported csv file, a generic non-descriptive "500 - Internal Server Error" is returned or new CREs are wrongfully injected.

More specifically, in the outlined case, if the format of "CRE 0" column is XX-XXX| instead of XXX-XXX|, a non-descriptive error is returned. Also, I noticed that if in the "<standard_name>|name" column the requirement's text is enclosed between three double quotes '"""', the csv is treated as valid and the whole row is entered as a new root CRE.

image

@filipposfwt filipposfwt changed the title Input validations missing on import csv functionality Input validation missing on import csv functionality Sep 18, 2024
@northdpole northdpole added enhancement New feature or request good first issue Good for newcomers GSOC this feature is a potential Google Summer of Code candidate labels Feb 22, 2025
@Hardik301002
Copy link

Hi ,@northdpole , @filipposfwt

I have reviewed the issue and identified the missing input validation in the CSV import functionality. I plan to implement validation checks for headers, data formats, and security measures (such as preventing CSV injection). I will also ensure proper error handling and testing before submitting a fix.

Please assign this issue to me so I can start working on it. Let me know if you have any specific requirements or suggestions.

Thanks!

@northdpole
Copy link
Collaborator

@Hardik301002 just assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers GSOC this feature is a potential Google Summer of Code candidate
Projects
None yet
Development

No branches or pull requests

3 participants