Skip to content

Added few changes to repository_contributor file #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samyak003
Copy link
Collaborator

Fixes: #1353

@samyak003 samyak003 requested a review from arkid15r as a code owner April 16, 2025 19:11
Copy link
Contributor

coderabbitai bot commented Apr 16, 2025

Summary by CodeRabbit

  • New Features
    • Added the ability to filter top contributors by project in the contributors query. This allows users to view top contributors for a specific project in addition to existing organization-based filtering.

Walkthrough

The changes introduce an optional project argument to the top_contributors GraphQL query in the RepositoryContributorQuery class. The resolver method is updated to accept this new parameter and, when provided, filters the queryset of repositories to those whose project key matches the pattern "www-project-{project}", in a case-insensitive manner. The rest of the logic for retrieving and ranking top contributors remains unchanged.

Changes

File(s) Change Summary
backend/apps/github/graphql/queries/repository_contributor.py Added optional project argument to top_contributors query and updated resolver to filter by project.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Unify top contributors logic in a single GraphQL endpoint and avoid code duplication (#1353) The PR adds a project filter to the endpoint but does not show changes related to unification or duplication removal.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5ceaae and 2b7ad36.

📒 Files selected for processing (1)
  • backend/apps/github/graphql/queries/repository_contributor.py (2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
backend/apps/github/graphql/queries/repository_contributor.py (1)
backend/apps/github/models/repository.py (1)
  • project (150-152)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Run frontend e2e tests
  • GitHub Check: Run backend tests
  • GitHub Check: Run frontend unit tests
  • GitHub Check: CodeQL (javascript-typescript)
🔇 Additional comments (3)
backend/apps/github/graphql/queries/repository_contributor.py (3)

19-19: Well-structured addition of the optional project parameter.

The new optional project parameter is well-integrated into the GraphQL query definition, following the same pattern as the existing organization parameter.


22-22: Method signature and documentation properly updated.

The resolver method signature has been correctly updated to include the new project parameter with a default value of None. The docstring has also been updated with clear documentation for the parameter.

Also applies to: 30-30


57-59: Good implementation of project filtering.

The implementation correctly filters repositories by project key using a case-insensitive match. This is consistent with how the project key is handled elsewhere in the code (line 83 where the prefix is removed before returning).

The filter follows the same pattern as the existing organization filter, applying it conditionally only when the parameter is provided.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take a look at these cases and refactor/consolide the code making sure that DRY principle is followed throughout the entire code base.

// Feel free to PM me if you have more questions.

@arkid15r arkid15r marked this pull request as draft April 18, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify top contributors logic
2 participants