Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create blog #39

Merged
merged 15 commits into from
Dec 4, 2023
Merged

Create blog #39

merged 15 commits into from
Dec 4, 2023

Conversation

miyaji255
Copy link
Contributor

No description provided.

@miyaji255 miyaji255 marked this pull request as draft November 23, 2023 12:23
@miyaji255 miyaji255 marked this pull request as ready for review November 24, 2023 13:00
@miyaji255 miyaji255 requested a review from ciffelia November 24, 2023 13:00
ciffelia
ciffelia requested changes Dec 3, 2023
View reviewed changes
Copy link
Member

@ciffelia ciffelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなりました 🙇
Astroのcontents collectionで実装していただいてありがとうございます。全体としては問題ないですが、何点かコメント入れてるのでそこだけ修正お願いします。

<Icon />の表示がSafariやFirefoxでバグる件については、このPRではとりあえずChromeで動いていればOKでもいいと思います。現在のインラインSVGを使った実装にはブラウザによって挙動が不安定という問題があるので、私が別PRで根本的に解決しようと思います。

astro.config.ts Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
README_BLOG.md Show resolved Hide resolved
README_BLOG.md Outdated Show resolved Hide resolved
src/pages/blog/tags/[slug]/index.astro Outdated Show resolved Hide resolved
src/pages/blog/authors/[slug]/index.astro Outdated Show resolved Hide resolved
src/components/blog/OgImage.ts Outdated Show resolved Hide resolved
src/components/layout/nav/Header.astro Outdated Show resolved Hide resolved
src/components/blog/BlogListItem.astro Outdated Show resolved Hide resolved
ciffelia
ciffelia approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@ciffelia ciffelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@miyaji255 miyaji255 merged commit 0f44163 into main Dec 4, 2023
6 checks passed
@miyaji255 miyaji255 deleted the create-blog branch December 4, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciffelia ciffelia ciffelia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miyaji255 @ciffelia