Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-UTF-8 in LogFormatter #73

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

robinkar
Copy link
Contributor

@robinkar robinkar commented Feb 4, 2025

The LogFormatter previously raised "invalid byte sequence in UTF-8 (ArgumentError)" for any non-UTF-8 logging due to strip not supporting non-UTF-8 strings.
This PR encodes the strings as UTF-8 before running strip on them.

See OSC/ondemand#4118 for more context on the issues this solves.

The LogFormatter previously raised "invalid byte sequence in UTF-8
(ArgumentError)" for any non-UTF-8 logging due to strip not supporting
non-UTF-8 strings.
@johrstrom johrstrom merged commit 9cb39d8 into OSC:main Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants