Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add term colors #397

Closed
wants to merge 14 commits into from
Closed

Add term colors #397

wants to merge 14 commits into from

Conversation

johrstrom
Copy link
Contributor

Replace #395 and it's branch because it got all jacked up during merges/rebases with master.

@samirmansour samirmansour self-assigned this Feb 14, 2020
@samirmansour samirmansour removed their request for review February 14, 2020 17:50
@samirmansour
Copy link
Contributor

Just a note. It doesn't seem like the termite and hyper color scheme files are working. The parser expects a few properties and the files I have found so far have not provided those properties. Hyper color schemes involve nodejs and does not work with the color scheme implementation ex https://github.com/leo/hyper-native

@johrstrom
Copy link
Contributor Author

I tried this and it immediatly crashed with this error. I take it it doesn't like the fact I don't have any schemeFiles (err directory)?

TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at getSchemeFilesArray (/users/PZS0714/johrstrom/ondemand/misc/ondemand/apps/shell/app.js:81:19)
    at /users/PZS0714/johrstrom/ondemand/misc/ondemand/apps/shell/app.js:284:99
    at Layer.handle [as handle_request] (/users/PZS0714/johrstrom/ondemand/misc/ondemand/apps/shell/node_modules/express/lib/router/layer.js:95:5)
    at next (/users/PZS0714/johrstrom/ondemand/misc/ondemand/apps/shell/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/users/PZS0714/johrstrom/ondemand/misc/ondemand/apps/shell/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/users/PZS0714/johrstrom/ondemand/misc/ondemand/apps/shell/node_modules/express/lib/router/layer.js:95:5)
    at /users/PZS0714/johrstrom/ondemand/misc/ondemand/apps/shell/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/users/PZS0714/johrstrom/ondemand/misc/ondemand/apps/shell/node_modules/express/lib/router/index.js:335:12)
    at next (/users/PZS0714/johrstrom/ondemand/misc/ondemand/apps/shell/node_modules/express/lib/router/index.js:275:10)

@ericfranz ericfranz changed the base branch from master to terminal-decouple April 6, 2020 20:11
@ericfranz ericfranz changed the base branch from terminal-decouple to master April 6, 2020 20:12
@ericfranz
Copy link
Contributor

So the original goal was to have these two as separate PRs/branches, now they are coupled together as one big PR/branch... that makes it hard to review and test separately. Thoughts?

@johrstrom johrstrom deleted the add-term-colors branch June 17, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell: Reconnect - Decouple terminal sessions from connections Shell: Shell Themes
3 participants