From 06ee6116190af961b278f3830352ced4971e1a41 Mon Sep 17 00:00:00 2001 From: Silvan Mosberger Date: Mon, 20 Jan 2025 19:45:28 +0100 Subject: [PATCH] ci/request-reviews: Don't fail when there's too many reviewers It's better than getting failed CI and emails: https://github.com/NixOS/nixpkgs/pull/371528#issuecomment-2573926369 And fix a shellcheck lint --- ci/request-reviews/request-reviewers.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/request-reviews/request-reviewers.sh b/ci/request-reviews/request-reviewers.sh index ee5664f04cbb36..1c105e385d28c6 100755 --- a/ci/request-reviews/request-reviewers.sh +++ b/ci/request-reviews/request-reviewers.sh @@ -69,8 +69,8 @@ for user in "${!users[@]}"; do done if [[ "${#users[@]}" -gt 10 ]]; then - log "Too many reviewers (${!users[@]}), skipping review requests" - exit 1 + log "Too many reviewers (${!users[*]}), skipping review requests" + exit 0 fi for user in "${!users[@]}"; do