Fix PyAction OpmLog #4440
Merged
Fix PyAction OpmLog #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
lisajulia
force-pushed
the
fix/pyAction-OpmLog
branch
from
4b55ea1 to
0f0539c
Compare
|
jenkins build this please |
bska
reviewed
Jan 22, 2025
blattms
reviewed
Jan 22, 2025
There was a problem hiding this comment.
I've now added a test for this (07fb927) and made the test pass.
@lisajulia Are you referring to #4441 ? Seems like the last jenkins build there failed?
lisajulia
force-pushed
the
fix/pyAction-OpmLog
branch
from
0f0539c to
b482f65
Compare
lisajulia
force-pushed
the
fix/pyAction-OpmLog
branch
from
b482f65 to
dbc2b4e
Compare
Yes exactly :) |
|
jenkins build this please |
bska
approved these changes
Jan 23, 2025
blattms
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes logging messages with the OpmLog from embedded Python code.
This used to work and then stopped working at some point, I've now added a test for this (07fb927) and made the test pass.
The issue was that the internal logger of the static class OpmLog was not set when OpmLog was called from embedded python code.
I have added a function setLogger to the OpmLog such that the Logger can be set using a python function on the python object OpmLog.
I'm happy to discuss other approaches to this!