ta: os_test: fix TA time wrap test #771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Jan 28, 2025
|
Yeah, I don't know. Maybe it's only starving the TA for CPU time. |
In the test for wrapped TA time in test_time() we check that the time has wrapped and that not too much time has passed. The limit for this is currently 2 seconds of which 1 second is passed in TEE_Wait(). This is currently not enough time with the recent introduction of fTPM being probed in parallel with the test. So in order to avoid occasional false negatives increase the limit to 60 seconds. Fixes: a2c1ce3 ("ta: os_test: fix TA time wrap test") Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
jenswi-linaro
force-pushed
the
wrapped_time_fix
branch
from
5c854ef to
9636ad4
Compare
|
Tag applied |
etienne-lms
reviewed
Jan 28, 2025
| @@ -623,7 +623,7 @@ static TEE_Result test_time(void) | |||
| } | |||
| MSG("TA time %"PRIu32".%03"PRIu32, t.seconds, t.millis); | |||
|
|
|||
| if (t.seconds > 1) { | |||
| if (t.seconds > 60) { | |||
There was a problem hiding this comment.
Test at line 603 is not impacted by the same CPU overload issue?
There was a problem hiding this comment.
I don't know, it's at least far less likely since we're not exiting to the normal world in between.
There was a problem hiding this comment.
Maybe fragile, depends on the scheduler. Won't this trigger rare CI test failures?
There was a problem hiding this comment.
Sure, I'll increase the time there too.
Addressing a comment. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
|
Update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test for wrapped TA time in test_time() we check that the time has wrapped and that not too much time has passed. The limit for this is currently 2 seconds of which 1 second is passed in TEE_Wait(). This is currently not enough time with the recent introduction of fTPM being probed in parallel with the test. So in order to avoid occasional false negatives increase the limit to 60 seconds.
Fixes: a2c1ce3 ("ta: os_test: fix TA time wrap test")