xtest: add SM4 perf test #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Feb 19, 2024
host/xtest/aes_perf.c
Outdated
| @@ -203,7 +211,7 @@ static void usage(const char *applet_optname, int keysize, int mode, | |||
| fprintf(stderr, " -i|--in-place Use same buffer for input and output (decrypt in place)\n"); | |||
| fprintf(stderr, " -k SIZE Key size in bits: 128, 192 or 256 [%u]\n", keysize); | |||
| fprintf(stderr, " -l LOOP Inner loop iterations [%u]\n", l); | |||
| fprintf(stderr, " -m MODE AES mode: ECB, CBC, CTR, XTS, GCM [%s]\n", mode_str(mode)); | |||
| fprintf(stderr, " -m MODE mode: AES-ECB, AES-CBC, AES-CTR, AES-XTS, AES-GCM, SM4-ECB, SM4-CBC, SM4-CTR, SM4-XTS [%s]\n", mode_str(mode)); | |||
There was a problem hiding this comment.
No. The modes should not be changed. ECB is a mode, AES-ECB is not: it is a combination of a cipher and a mode. Please add a -c|--cipher option with values AES and SM4 (default AES).
(Another option would be to keep your suggestion but change "-m MODE" to "-a ALGO", but I prefer two separate options because no need to expand the list of all combinations).
Also please do not forget to change:
fprintf(stderr, "AES performance testing tool for OP-TEE\n");-> "AES/SM4 performance testing..."
yuzexiyzx
force-pushed
the
master
branch
2 times, most recently
from
50828ab to
36a6595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add perf test for SM4 algorithm