Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plat-versal2: disable ARM CE v8.2 #7265

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Akshay-Belsare
Copy link
Contributor

Disable ARM CE configs for SHA-512 and SHA3 as those are not available on the SoC.
Ensure that the ARM CE configuration can be overridden at runtime while the default value remains enabled.

@jenswi-linaro
Copy link
Contributor

Ensure that the ARM CE configuration can be overridden at runtime while the default value remains enabled.

What do you mean by that? The CE configuration is a compile-time option.

So of the 8.2 crypto extensions you support SM3 and SM4 but have them implicitly disabled via

$(call force,CFG_CRYPTO_SM3,n)
$(call force,CFG_CRYPTO_SM4,n)

Am I missing something?

@jenswi-linaro
Copy link
Contributor

Please squash the commits and update the commit message.

@michalsimek
Copy link

Works for me
Acked-by: Michal Simek michal.simek@amd.com

@Akshay-Belsare Akshay-Belsare force-pushed the amd_versal2_support branch 3 times, most recently from ab2692a to 6f7d201 Compare February 6, 2025 13:41
@jenswi-linaro
Copy link
Contributor

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

Disable the ARM CE v8.2 configuration since it is not available on the SoC.
Allow the ARM CE configuration to be overridden at build time while keeping
the default value enabled.

Signed-off-by: Amey Avinash Raghatate <AmeyAvinash.Raghatate@amd.com>
Signed-off-by: Akshay Belsare <akshay.belsare@amd.com>
Acked-by: Michal Simek <michal.simek@amd.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
@Akshay-Belsare Akshay-Belsare changed the title plat-versal2: disable ARM CE crypto algo SHA512 and SHA3 plat-versal2: disable ARM CE v8.2 Feb 7, 2025
@Akshay-Belsare
Copy link
Contributor Author

@jforissier the change is ready to be merged.

@jforissier jforissier merged commit 71aed2d into OP-TEE:master Feb 11, 2025
11 checks passed
@Akshay-Belsare Akshay-Belsare deleted the amd_versal2_support branch March 6, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants