plat-rockchip: rk3588: Allow Passing of Devicetree #7254
Conversation
|
These changes hang the NanoPC-T6, including the TF-A |
|
That seems to be a very old version of U-Boot. Any reason you're still using that? That's not the Rockchip BSP version is it? |
|
It's NanoPC-T6 U-Boot nanopi5-v2017.09, maintained by the vendor. It lacks |
|
|
Please use: |
Increase the maximum size of the FDT to 384KiB to match the proposed changes with Arm Trusted Firmware. This allows us to pass and parse the FDT within OP-TEE. When doing this, we also need to allow OP-TEE to detect the maximum PA bits so that allocating RAM above 4GiB does not fail. With these two changes, OP-TEE can parse and add the correct memory nodes to the devicetree passed to it automatically. Associated A-TF commit: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/34997 Signed-off-by: Chris Morgan <macromorgan@hotmail.com> Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Update the TZDRAM_START and SHMEM_START values to match the PX30 and RK3399 values. If this is not done, a compressed kernel using the default value of kernel_comp_addr_r (0x0a000000) within U-Boot and having a decompressed size greater than 28MiB puts the decompressed kernel in the reserved address space for OP-TEE that starts at 0x08400000. Using the values for the RK3399 and PX30 avoids this problem. Fixes: 14754b9 ("plat-rockchip: add support for Rockchip rk3588") Signed-off-by: Chris Morgan <macromorgan@hotmail.com> Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
macromorgan
force-pushed
the
rk3588_fixes
branch
from
8346292 to
6ab32ac
Compare
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
In order to pass the devicetree from the first stage bootloader through Arm Trusted Firmware and into Optee, we need to increase the max allowable size of the FDT. 128KiB is enough today for my specific use case (an Indiedroid Nova), however if we add symbols and allow for future growth using a larger value would be prudent. Arm Trusted Firmware today has a hard limit with its current configuration of slightly above 512KiB, so set it to 384KiB to allow for future growth of also Arm Trusted Firmware code.
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/34997
Additionally, U-Boot today uses an address for compressed kernels by default that is very close to the address used by Optee. As a result, if we use the default values from both projects the system will fail to boot when Optee is used. Update the TZDRAM_START and SHMEM_START to values used by RK3399 and PX30, which uses addresses not in use today by U-Boot.