Allow NIST curves on all ECDSA algorithms in libtomcrypt and libutee #7249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to GP TEE specification "ECDSA algorithm identifiers should be tied to the size of the digest, not the key.". Therefore allow use of any TEE_ALG_ECDSA_SHA* algorithm for any of the supported NIST curves. Reported-by: Anvisha <quic_anvisriv@quicinc.com> Closes: OP-TEE/optee_test#721 (comment) Link: OP-TEE#6230 Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
According to GP TEE specification "ECDSA algorithm identifiers should be tied to the size of the digest, not the key.". Therefore allow use of any TEE_ALG_ECDSA_SHA* algorithm for any of the supported NIST curves. Reported-by: Anvisha <quic_anvisriv@quicinc.com> Closes: OP-TEE/optee_test#721 (comment) Link: OP-TEE#6230 Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
jforissier
reviewed
Jan 30, 2025
jforissier
reviewed
Jan 30, 2025
| @@ -2713,6 +2730,7 @@ TEE_Result TEE_IsAlgorithmSupported(uint32_t alg, uint32_t element) | |||
| } | |||
|
|
|||
| return TEE_ERROR_NOT_SUPPORTED; | |||
|
|
|||
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
|
Please keep alive. I'll work back on this topic soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to GP TEE specification "ECDSA algorithm identifiers should be tied to the size of the digest, not the key.". Therefore allow use of any
TEE_ALG_ECDSA_SHA*algorithm for any of the supported NIST curve.The constraint removed by these changes are present only in libutee and libtomcrypt.