Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #549 #560

Merged
merged 10 commits into from
Jan 15, 2025
Merged

Fix issue #549 #560

merged 10 commits into from
Jan 15, 2025

Conversation

duprijil
Copy link
Collaborator

@duprijil duprijil commented Jan 8, 2025

Fixes: #549

Additionally, it fixes the issue regarding notice publication id with spaces requested in meeting (Mets Packages for TED RDF) from 9th of December 2024.

Example of potential problem showed in meeting:

<cac:NoticeDocumentReference>
<cbc:ID schemeName="ojs-notice-id">   474946-2024</cbc:ID>
</cac:NoticeDocumentReference>

@duprijil duprijil requested a review from Dragos0000 January 8, 2025 16:00
@duprijil duprijil self-assigned this Jan 8, 2025
@duprijil duprijil linked an issue Jan 8, 2025 that may be closed by this pull request
@duprijil duprijil linked an issue Jan 8, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (no_libraries@17d8e24). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             no_libraries     #560   +/-   ##
===============================================
  Coverage                ?   96.44%           
===============================================
  Files                   ?      108           
  Lines                   ?     5602           
  Branches                ?        0           
===============================================
  Hits                    ?     5403           
  Misses                  ?      199           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duprijil duprijil merged commit adc2f3f into no_libraries Jan 15, 2025
4 checks passed
@duprijil duprijil deleted the feature/SWS1-12 branch January 15, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle parsing issues in METs packages
3 participants