moved the if condition with uploadNewEndpoint() before the approveCollection()

Author: BarathaAberathne

zebedee-cms/src/main/java/com/github/onsdigital/zebedee/model/approval/ApproveTask.java

@@ -164,6 +164,10 @@ private boolean doApproval() throws Exception {
             compressZipFiles(collection, collectionReader, collectionWriter);
             eventLog.compressedZipFiles();
 
+            if (Configuration.isUploadNewEndpointEnabled() && DatasetWhitelistChecker.isURIWhitelisted(collectionReader)) {
+                uploadNewEndpoint(collection, collectionReader);
+            }
+            
             approveCollection();
             eventLog.approvalStateSet();
 
@@ -175,10 +179,6 @@ private boolean doApproval() throws Exception {
             info().data("user", session.getEmail()).data("collectionId", collection.getDescription().getId())
                     .log("approve task: collection approve task completed successfully");
 
-            if (Configuration.isUploadNewEndpointEnabled() && DatasetWhitelistChecker.isURIWhitelisted(collectionReader)) {
-                uploadNewEndpoint(collection, collectionReader);
-            }
-
             return collection != null;
 
         } catch (Exception e) {