Upgrade wdio local-runner to to v9.9.3 #1610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berroar
force-pushed
the
upgrade-wdio-runner-to-v9
branch
from
3e97627 to
f4b75ac
Compare
berroar
changed the title
berroar
commented
Feb 21, 2025
Comment on lines
-13
to
-27
| describe("Given the user starts on the 'do you live here' question", () => { | ||
| before("Load the survey", async () => { | ||
| await browser.openQuestionnaire("test_list_collector_primary_person.json"); | ||
| }); | ||
|
|
||
| it.skip("When the user says they do not live there, and changes their answer to yes, then the user can't navigate to the list collector", async () => { | ||
| await $(PrimaryPersonListCollectorPage.noLabel()).click(); | ||
| await click(PrimaryPersonListCollectorPage.submit()); | ||
| await $(PrimaryPersonListCollectorAddPage.previous()).click(); | ||
| await $(PrimaryPersonListCollectorPage.yesLabel()).click(); | ||
| await click(PrimaryPersonListCollectorPage.submit()); | ||
| await browser.url("questionnaire/list-collector"); | ||
| await expect(await $(PrimaryPersonListCollectorPage.questionText()).getText()).toBe("Do you live here"); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Removing as test is broken and has been set with it.skip for years.
VirajP1002
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Upgrades the wdio
local-runnerlibrary tov9.9.3and bumps the other wdio libraries to their latest versions.Previously we had to pin the wdio local-runner library because upgrading caused issues when we used .getHTML in our functional tests. This PR upgrades the libraries and fixes any broken tests
- Uses .getText() instead of getHTML() in some places where we weren't checking for html.
- Uses the
includeSelectorTagparam for the .getHTML method to fix some of the issues caused by the upgrade.- Upgading caused some other tests to fail and highlighted other bugs .e.g. fixing issues where questionnaires were being opened multiple times and bumping timeouts to resolve flakiness.
- Updates the click method in helpers.js to resolve scroll into view warnings from the wdio log files.
How to review
Check the changes and ensure that the functional test suite is passing
Checklist