Apply appropriate display width for radio and checkbox detail answers (#82)

Author: berroar

app/jinja_filters.py

@@ -241,8 +241,10 @@ def __init__(self, option, index, form, answer):
         self.label = LabelConfig(option.id, option.label.text, label_description)
 
         if option.detail_answer_id:
-            detail_answer = form["fields"][option.detail_answer_id]
-            self.other = OtherConfig(detail_answer)
+            detail_answer_field = form["fields"][option.detail_answer_id]
+            detail_answer_schema = answer_option["detail_answer"]
+
+            self.other = OtherConfig(detail_answer_field, detail_answer_schema)
 
 
 class RadioConfig:
@@ -261,9 +263,10 @@ def __init__(self, option, index, form, answer):
         self.label = LabelConfig(option.id, option.label.text, label_description)
 
         if option.detail_answer_id:
-            detail_answer = form["fields"][option.detail_answer_id]
-            answer_visible = answer_option["detail_answer"].get("visible", False)
-            self.other = OtherConfig(detail_answer, answer_visible)
+            detail_answer_field = form["fields"][option.detail_answer_id]
+            detail_answer_schema = answer_option["detail_answer"]
+
+            self.other = OtherConfig(detail_answer_field, detail_answer_schema)
 
 
 class RelationshipRadioConfig:
@@ -292,12 +295,16 @@ def __init__(self, option, index, answer):
 
 
 class OtherConfig:
-    def __init__(self, detail_answer, answer_visible=False):
-        self.open = answer_visible
-        self.id = detail_answer.id
-        self.name = detail_answer.name
-        self.value = escape(detail_answer._value())  # pylint: disable=protected-access
-        self.label = LabelConfig(detail_answer.id, detail_answer.label.text)
+    def __init__(self, detail_answer_field, detail_answer_schema):
+        self.id = detail_answer_field.id
+        self.name = detail_answer_field.name
+        self.value = escape(
+            detail_answer_field._value()
+        )  # pylint: disable=protected-access
+        self.label = LabelConfig(detail_answer_field.id, detail_answer_field.label.text)
+        self.open = detail_answer_schema.get("visible", False)
+        if detail_answer_schema["type"] == "Number":
+            self.classes = get_width_class_for_number(detail_answer_schema)
 
 
 @blueprint.app_template_filter()

tests/app/test_jinja_filters.py

@@ -218,6 +218,36 @@ def test_radio_class_visible_attribute():
 
         assert radio.other.open is True
 
+    @staticmethod
+    def test_radio_class_detail_answer_display_width_with_max_value():
+        answer = {
+            "type": "Radio",
+            "id": "radio-answer-numeric-detail",
+            "mandatory": False,
+            "options": [
+                {
+                    "label": "Other",
+                    "value": "Other",
+                    "detail_answer": {
+                        "mandatory": False,
+                        "id": "other-answer",
+                        "label": "Please enter a number of items",
+                        "type": "Number",
+                        "maximum": {"value": 20},
+                        "parent_id": "radio-question-numeric-detail",
+                        "visible": False,
+                    },
+                }
+            ],
+            "parent_id": "radio-question-numeric-detail",
+        }
+
+        option = Mock()
+        option.detail_answer_id = "other-answer"
+        radio = RadioConfig(option=option, index=0, form=MagicMock(), answer=answer)
+
+        assert radio.other.classes == "input--w-2"
+
 
 def test_map_list_collector_config_no_actions():
     list_items = [{"item_title": "Mark Bloggs"}, {"item_title": "Joe Bloggs"}]