Glossary terms snippet #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
requested changes
Mar 5, 2025
cms/jinja2/templates/components/streamfield/glossary_section_block.html
Outdated
Show resolved
Hide resolved
zerolab
reviewed
Mar 5, 2025
zerolab
reviewed
Mar 5, 2025
… follow after the final decision is made
MebinAbraham
reviewed
Mar 6, 2025
AdamHawtin
approved these changes
Mar 11, 2025
AdamHawtin
reviewed
Mar 11, 2025
zerolab
reviewed
Mar 11, 2025
Merged
zerolab
approved these changes
Mar 12, 2025
MebinAbraham
approved these changes
Mar 12, 2025
zerolab
reviewed
Mar 12, 2025
sanjeevz3009
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
LGTM. No comments apart from the existing convos already going on + the need to get one of the UI tests passing. Tested everything locally and everything works as expected.
@kacperpONS A loom video would be a nice addition, a gentle reminder.
…he latest revision instead
zerolab
reviewed
Mar 12, 2025
kacperpONS
requested review from
zerolab,
AdamHawtin,
sanjeevz3009 and
MebinAbraham
zerolab
approved these changes
Mar 13, 2025
sanjeevz3009
approved these changes
Mar 13, 2025
MebinAbraham
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
We want to add the Glossary term snippet and allow it to be used on Methodology and Statistical Article pages.
How to review
Make sure code looks ok, run tests.
Links
https://jira.ons.gov.uk/browse/CMS-81
Loom recording: https://www.loom.com/share/c053a155c6384b50b94f0b13a759cbd9?sid=febc7d52-7e9d-460c-a8e5-04320ad82465