Draft: add bar and column charts #3512
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenb
commented
Mar 10, 2025
| @@ -1,5 +1,9 @@ | |||
| class SpecificChartOptions { | |||
| constructor(theme, type) { | |||
| constructor(theme, type, useStackedLayout, config) { | |||
There was a problem hiding this comment.
@precious-onyenaucheya-ons I think this file is getting less useful and more of a sprawl now. I'd like to refactor it so that we start to have all the specific options just in bar-chart.js, line-chart.js etc. I'm going to look into this as part of this PR if you're happy with that appraoch.
helenb
commented
Mar 11, 2025
| @@ -135,5 +135,6 @@ | |||
| }, | |||
| "dependencies": { | |||
| "highcharts": "^12.1.2" | |||
| } | |||
| }, | |||
| "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | |||
There was a problem hiding this comment.
@precious-onyenaucheya-ons I assume I should remove this change - I think yarn added it automatically.
There was a problem hiding this comment.
yes please
helenb
force-pushed
the
feature/set-up-highchart
branch
from
6b74f6d to
19efeaa
Compare
…egory labels in bar charts
…ct as deep as necessary
helenb
force-pushed
the
feature/bar-and-column-charts
branch
from
b9d02df to
db95d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This PR will add the bar and column charts to the design system.
WIP for now to show Precious what I am working on.
Builds on #3506
How to review this PR
Describe the steps required to test the changes (include screenshots if appropriate).
Checklist
This needs to be completed by the person raising the PR.