Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output/buffer: Change buffer-size default value #12696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlucovsky
Copy link
Contributor

@jlucovsky jlucovsky commented Feb 28, 2025

The buffer-size value that controls file output buffering defaults to 8k. To be consistent with previous logic, the default is being changed to 0 (e.g., needed if there are old config files that don't specifically enable the new value).

Link to ticket: https://redmine.openinfosecfoundation.org/issues/3449

Describe changes:

  • Ensure default value for buffer-size is 0, even with old config files.

Provide values to any of the below to override the defaults.

  • To use an LibHTP, Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

The buffer-size value that controls file output buffering defaults to
8k. To be consistent with previous logic, the default is being changed
to 0 (e.g., needed if there are old config files that don't specifically
enable the new value).
@jlucovsky jlucovsky requested review from victorjulien and a team as code owners February 28, 2025 16:05
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (2e52e95) to head (9f7abb3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12696      +/-   ##
==========================================
- Coverage   80.72%   80.72%   -0.01%     
==========================================
  Files         936      936              
  Lines      259393   259393              
==========================================
- Hits       209398   209397       -1     
- Misses      49995    49996       +1     
Flag Coverage Δ
fuzzcorpus 56.97% <100.00%> (-0.01%) ⬇️
livemode 19.41% <100.00%> (-0.01%) ⬇️
pcap 44.22% <100.00%> (+<0.01%) ⬆️
suricata-verify 63.51% <100.00%> (-0.02%) ⬇️
unittests 58.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 637 616 96.7%

Pipeline 24941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants