tool: rewrite suricatasc and suricatactl in rust - v16 #12682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a re-implementation of suricatasc program in Rust that attempts to be a 100% drop-in replacement.
As we have 2 Windows builds, do one using the release-style distribution file.
These should probably be removed even without the rewrite, and suricatasc has been installed as a proper program for many releases.
After a build, check if Cargo.lock.in and Cargo.lock differ, if so, Cargo.lock.in needs an update as part of a depedency update.
Without this script `make distcheck` fails on a system with documentation tooling installed, as its required to build the EVE appendix.
There will be changes in our development branch that the RPMs need to adapt to, but that can't be done until the changes have been merged to master, then the RPM can catchup. This gives us a single variable to turn off RPM building.
RPMs will need to be fixed after merge.
jasonish
requested review from
inashivb,
jufajardini and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12682 +/- ##
==========================================
- Coverage 80.71% 80.71% -0.01%
==========================================
Files 935 936 +1
Lines 259405 259415 +10
==========================================
+ Hits 209389 209392 +3
- Misses 50016 50023 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24920 |
victorjulien
approved these changes
Feb 27, 2025
Merged
|
Merged in #12685, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase.