Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: move unit tests to suricata-verify #12677

Closed

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/3725
https://redmine.openinfosecfoundation.org/issues/7529

Describe changes:

  • dns: (re)move unit tests to suricata-verify

Tests were already merged in Suricata-Verify OISF/suricata-verify#2297

Ticket: 3725
Ticket: 7529
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (3bc2a14) to head (65aad9f).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12677      +/-   ##
==========================================
- Coverage   80.77%   80.74%   -0.03%     
==========================================
  Files         932      932              
  Lines      259517   259064     -453     
==========================================
- Hits       209629   209190     -439     
+ Misses      49888    49874      -14     
Flag Coverage Δ
fuzzcorpus 57.00% <ø> (+0.01%) ⬆️
livemode 19.36% <ø> (-0.01%) ⬇️
pcap 44.17% <ø> (+0.01%) ⬆️
suricata-verify 63.50% <ø> (-0.01%) ⬇️
unittests 58.25% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24893

@victorjulien victorjulien added this to the 8.0 milestone Feb 26, 2025
@victorjulien
Copy link
Member

Merged in #12679, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants