ftp: begin conversion process to Rust #12657
Conversation
As part of the effort to convert the FTP/FTPDATA parser to rust, move the enums from C to rust. Issue: 4082
Issue: 4082 Move the configuration file handling to Rust. These changes will no longer terminate Suricata when there's an invalid value for ftp.memcap. Like earlier Suricata releases, an error message is logged "Invalid value <value> for ftp.memcap" but Suricata will no longer terminate execution. It will use a default value of "0" instead.
jlucovsky
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12657 +/- ##
==========================================
- Coverage 80.77% 80.71% -0.06%
==========================================
Files 932 934 +2
Lines 259517 259586 +69
==========================================
- Hits 209629 209533 -96
- Misses 49888 50053 +165
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24862 |
There was a problem hiding this comment.
Thanks for the work :-)
CI : 🟢 not sure about QA time
Code : looking now
Commits segmentation :ok
Commit messages : good
Git ID set : looks fine for me
CLA : you already contributed
Doc update : typo double space Suricata releases ;-)
Redmine ticket : ok
Rustfmt : ok
Tests : ok
Dependencies added: none
|
|
||
| /// cbindgen:ignore | ||
| extern "C" { | ||
| pub fn MpmAddPatternCI( |
There was a problem hiding this comment.
This should live in another file like rust/src/core.rs ;-)
There was a problem hiding this comment.
Jeff can you track this for post-merge?
|
Merged in #12675, thanks! |
Continuation of #12639
ftp: Partial conversion of the FTP protocol parser to Rust.
This PR represents partial completion of issue 4082.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/4082
Describe changes:
Updates:
Behavioral change
Previous versions of Suricata terminated execution if
ftp.memcapcontained an invalid value. An error message was displayed before exiting. The changes in this PR continue to print the error message in this case; instead of terminating Suricata, Suricata will continue execution and use a value of0forftp.memcap. This is noted in the upgrade notes.Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2273
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=