dcerpc: consume bytes after gap resync #12649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7567 After a gap, we search a new record that may start later than the beginning of current stream slice. If so, consume the first bytes before the start of the record, so that AppLayerResult::incomplete can be consistent and not trigger assertion !((res.needed + res.consumed < input_len))
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12649 +/- ##
=======================================
Coverage 80.76% 80.76%
=======================================
Files 932 932
Lines 259381 259383 +2
=======================================
+ Hits 209484 209488 +4
+ Misses 49897 49895 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
inashivb
approved these changes
Feb 21, 2025
|
Will need a rebase for clean CI post clippy fixes merge though |
|
Information: QA ran without warnings. Pipeline 24857 |
victorjulien
approved these changes
Feb 22, 2025
Merged
|
Merged in #12675, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7567
Describe changes: