detect: allow rule which need both directions to match #12646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
requested review from
jufajardini and
victorjulien
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12646 +/- ##
==========================================
- Coverage 80.77% 80.75% -0.03%
==========================================
Files 932 932
Lines 259517 259699 +182
==========================================
+ Hits 209629 209707 +78
- Misses 49888 49992 +104
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Red CI because needs #12647 |
|
Information: QA ran without warnings. Pipeline 24858 |
Ticket: 5665 This is done with `alert ip any any => any any` The => operator means that we will need both directions
catenacyber
force-pushed
the
detect-bidir-5665-v21
branch
from
62192fc to
454c31d
Compare
|
Rebased to get green CI |
|
Information: QA ran without warnings. Pipeline 24870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5665
Describe changes:
SV_BRANCH=OISF/suricata-verify#2083
#12405 with improved doc after review and fix for new assertion
BUG_ON(count_final_sm_list == 0);Ongoing question : usage of new keyword
bidir.toserveror tweakingflow: toserver(or something else) in the case of a bidirectional signature with direction-ambiguous keywords ?