Applayer plugin 5053 v13 #12635
Closed
Applayer plugin 5053 v13 #12635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
requested review from
jasonish,
jufajardini,
victorjulien and
a team
as code owners
|
ERROR: ERROR: QA failed on build_asan. Pipeline 24830 |
catenacyber
force-pushed
the
applayer-plugin-5053-v13
branch
from
6df1952 to
1a62b6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12635 +/- ##
==========================================
+ Coverage 80.77% 80.80% +0.02%
==========================================
Files 932 932
Lines 259517 259884 +367
==========================================
+ Hits 209629 210002 +373
+ Misses 49888 49882 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
red CI before merge of #12647 to be rebased after |
|
Information: QA ran without warnings. Pipeline 24864 |
and use generic logger callback prototype with later cast and do some other small modifications so that the plugin has less diff
so that it can be used by plugins Avoid export by cbindgen as this constant is also defined in C
including the tx parameter to the logger function
Ticket: 7151 Ticket: 7152 Ticket: 7154
Ticket: 7149 Ticket: 7150 Ticket: 7153
catenacyber
force-pushed
the
applayer-plugin-5053-v13
branch
from
1a62b6a to
c1cd73f
Compare
|
Information: QA ran without warnings. Pipeline 24874 |
|
Next in #12667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/4102 with all 6 subtickets
Describe changes:
#12536 with needed rebase after bindgen and suricata-sys introduction by @jasonish :-)
I think #12599 should come before that PR
And I think we would also want after that, another PR that splits suricata crate in 2 : like suricata-core which has 0 dependencies and can be used by plugins, and the rest of suricata