Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect/krb5: avoid integer underflow with krb5.ticket_encryption (backport7) #12632

Closed
wants to merge 1 commit into from
Closed

detect/krb5: avoid integer underflow with krb5.ticket_encryption (backport7) #12632

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

@catenacyber
detect/krb5: avoid integer underflow with krb5.ticket_encryption
b95f938 
Ticket: 7560

When passing INT32_MIN aka 0x80000000, we cannot compute -vali
as it does not fit into a i32

(cherry picked from commit 8ae5665)
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.27%. Comparing base (9516f0a) to head (b95f938).
Report is 10 commits behind head on main-7.0.x.

Additional details and impacted files 
@@             Coverage Diff             @@
##           main-7.0.x   #12632   +/-   ##
===========================================
  Coverage       83.27%   83.27%           
===========================================
  Files             922      922           
  Lines          261201   261208    +7     
===========================================
+ Hits           217504   217517   +13     
+ Misses          43697    43691    -6
Flag Coverage Δ
fuzzcorpus 64.30% <100.00%> (+<0.01%) ⬆️
suricata-verify 63.49% <100.00%> (-0.01%) ⬇️
unittests 62.37% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

inashivb
inashivb approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 146 141 96.58%
.flow.end.tcp_state.last_ack 0 1 -

Pipeline 24807

@victorjulien victorjulien mentioned this pull request Feb 21, 2025
Merged
@victorjulien
Copy link
Member

Merged in #12651, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

@inashivb inashivb inashivb approved these changes

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catenacyber @suricata-qa @victorjulien @inashivb