Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/738/70x/20250219/v1 #12630

Merged
merged 8 commits into from
Feb 20, 2025
Merged

next/738/70x/20250219/v1 #12630

merged 8 commits into from
Feb 20, 2025

Conversation

victorjulien
Copy link
Member

jasonish and others added 8 commits February 18, 2025 15:32
@jasonish
mqtt: always use 0x notation for hex in tests
2b6e5f8 
Fixes clippy lint for zero_prefixed_literal.
@jasonish
rust: allow vec_init_then_push in tests
c7ff76c 
To supress the clippy lint in tests.
@catenacyber @jasonish
rust: fix assertions_on_constants for assert!(false)
a40b37b 
using panic! instead with a string message

(cherry picked from commit a8199bf)
@catenacyber @jasonish
rust: fix single_binding
ab089b0 
error: this match could be written as a `let` statement
   --> src/nfs/nfs3_records.rs:747:9
    |
747 | /         match result {
748 | |             (r, request) => {
749 | |                 assert_eq!(r.len(), 0);
750 | |                 assert_eq!(request.handle, expected_handle);
751 | |                 assert_eq!(request.name_vec, br#"bln"#);
752 | |             }
753 | |         }
    | |_________^

(cherry picked from commit 259cdf1)
@catenacyber @jasonish
rust: fix assertions_on_constants for assert!(true)
57111f3 
Which will be optimized away by the compiler

(cherry picked from commit c49463c)
@inashivb @jasonish
dns: fix clippy lint warnings
17b8f1f 
Fix vector lint issues:
- same_item_push
- vec_init_then_push

(cherry picked from commit 2c0d3b8)
@jasonish
rust: allow clippy::unused_unit for tests that use the test macro
6666555 
The cause of the issue comes from the macro, which is provided by a
crate. Bust just to allow this for now.
@jasonish
dns: refactor tests to avoid assert!(false)
ac62d1b 
Mostly just unwrap instead of match as unwrap provides good
context. And replace a few assert!(false) with a descriptive panic.
@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 146 140 95.89%

Pipeline 24804

@victorjulien victorjulien merged commit ac62d1b into OISF:main-7.0.x Feb 20, 2025
88 checks passed
@victorjulien victorjulien mentioned this pull request Feb 20, 2025
Merged
@victorjulien victorjulien deleted the next/738/70x/20250219/v1 branch February 20, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@catenacyber catenacyber Awaiting requested review from catenacyber catenacyber is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@victorjulien @suricata-qa @jasonish @catenacyber @inashivb