Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/731/70x/20250218/v1 #12611

Merged
merged 1 commit into from
Feb 18, 2025
Merged

next/731/70x/20250218/v1 #12611

merged 1 commit into from
Feb 18, 2025

Conversation

victorjulien
Copy link
Member

@victorjulien
tls: more permissive empty data eof check
9516f0a 
If not all data is ACK'd during the FIN session shutdown, the last calls
to the parser can be with a non-NULL data pointer, but a input length of
0. This wasn't considered by the EOF check, which then lead to it being
seen as an error. No event was raised, but the tls error stats were
incremented.

Bug: OISF#7554.
(cherry picked from commit 471bde4)
inashivb
inashivb approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inashivb inashivb added the needs baseline update QA will need a new base line label Feb 18, 2025
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPW1_stats_chk
.app_layer.error.tls.parser 1206 1049 86.98%
SURI_TLPR1_stats_chk
.app_layer.error.tls.parser 23956 22493 93.89%

Pipeline 24766

@victorjulien
Copy link
Member Author

@ct0br0 can you prep a rebaseline for this?

@ct0br0
Copy link

ct0br0 commented Feb 18, 2025

This should be ready in QA lab. May have some uptime noise on TLPW2.

@victorjulien victorjulien merged commit 9516f0a into OISF:main-7.0.x Feb 18, 2025
88 checks passed
@victorjulien victorjulien mentioned this pull request Feb 18, 2025
Merged
@victorjulien victorjulien deleted the next/731/70x/20250218/v1 branch February 18, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

@inashivb inashivb inashivb approved these changes

Assignees
No one assigned
Labels
needs baseline update QA will need a new base line
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@victorjulien @suricata-qa @ct0br0 @jasonish @inashivb