Detect http uri sv 3725 v1 #11307
Closed
Detect http uri sv 3725 v1 #11307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11307 +/- ##
==========================================
- Coverage 82.45% 82.40% -0.06%
==========================================
Files 961 961
Lines 251710 249154 -2556
==========================================
- Hits 207552 205319 -2233
+ Misses 44158 43835 -323
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 21090 |
| @@ -1296,6 +1296,20 @@ int AppLayerParserParse(ThreadVars *tv, AppLayerParserThreadCtx *alp_tctx, Flow | |||
| uint32_t consumed = input_len; | |||
| const uint8_t direction = (flags & STREAM_TOSERVER) ? 0 : 1; | |||
|
|
|||
| #ifdef UNSAFE_DUMMY_SVTEST_CONVERSION | |||
There was a problem hiding this comment.
this commit is too messy to get merged
There was a problem hiding this comment.
removing the messy commit then :-)
|
Continued in #11315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/3725
Describe changes:
Thay all follow the same basis :
SV_BRANCH=OISF/suricata-verify#1917
Should we have the first helper dummy commit that helps create these tests ?