Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update eBPF/compilation instructions v7 #11221

Closed

Conversation

lukashino
Copy link
Contributor

@lukashino lukashino commented Jun 3, 2024

Follow-up of #11176

Link to Redmine tickets:

Describe changes:
v7

  • rebased on GitHub master branch

v6

  • added epel-release as recommended dependency for RPM-based systems
  • removed "Recommended" dependencies install command for both apt and dnf-based systems
  • cbindgen is installed with dnf in dnf-based systems

v5

  • inlined and shortened PATH variable edits in the RPM section
  • added minimal/recommended builds to the GH workflow from Ubuntu and Almalinux
  • added literalincludes to the docs from the Github builds
  • removed gosu from Github builds
  • added DPDK to the list of recommended dependencies

v4

  • inlined and shortened PATH variable edits in the Rust section
  • can be cloned - be added

v3

  • updates to the docs per Jeff's suggestions
  • removed the instruction to install i386 headers for the eBPF

v2

  • remove recommended configure parameters

v1

  • small edit in eBPF instructions to prefer libbpf-dev package to the cloning&compilation
  • porting changes from the improved version of installation instructions that got merged into master-6.0.x

@lukashino lukashino added the typo/doc update No code change : only doc or typo fixes label Jun 3, 2024
@lukashino lukashino self-assigned this Jun 3, 2024
@lukashino lukashino requested review from jasonish, jufajardini and a team as code owners June 3, 2024 06:53
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (3b1fecb) to head (d246ddb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11221   +/-   ##
=======================================
  Coverage   83.02%   83.02%           
=======================================
  Files         942      942           
  Lines      250606   250606           
=======================================
+ Hits       208067   208078   +11     
+ Misses      42539    42528   -11     
Flag Coverage Δ
fuzzcorpus 61.28% <ø> (ø)
livemode 18.74% <ø> (+0.03%) ⬆️
pcap 44.50% <ø> (-0.07%) ⬇️
suricata-verify 61.72% <ø> (+<0.01%) ⬆️
unittests 60.64% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lukashino lukashino removed their assignment Jun 7, 2024
@lukashino
Copy link
Contributor Author

Scripts should be put into a separate directory and from there loaded by the docs and by the Github Actions.

@lukashino
Copy link
Contributor Author

Replaced by #11278

@lukashino lukashino closed this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typo/doc update No code change : only doc or typo fixes
Development

Successfully merging this pull request may close these issues.

2 participants