pgsql: low hanging fruits - v2 #10853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was brought to my attention by GLongo that Pgsql parser handled eof diffrently for requests and responses, and apparently there isn't a good reason for such a difference therefore, apply same logic used for rs_pgsql_parse_request for checking for eof when parsing a response.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10853 +/- ##
==========================================
+ Coverage 82.83% 82.88% +0.05%
==========================================
Files 913 913
Lines 246847 246852 +5
==========================================
+ Hits 204474 204614 +140
+ Misses 42373 42238 -135
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Apr 16, 2024
|
Information: QA ran without warnings. Pipeline 20079 |
Merged
|
Merged in #10856, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While starting review for the LDAP protocol parser, noticed that we had a TODO for adding a simpler logger function for PGSQL, following up #9851.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6092
Previous PR: #10830
Describe changes:
These commits don't change the output behavior, just ensure that we pass pgsql config flags as metadata, therefore, these tests should pass with master, too.
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#1770