Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for initialImageIndex mismatch issue for loading SR after disabl… #4836

Open
wants to merge 2 commits into
base: release/3.9
Choose a base branch
from

Conversation

ashik-trenser
Copy link
Contributor

…ing prompts (#4732)

Context

Changes & Results

  • Added initial image options to the viewport options while setting the displaysets from trackedMeasurementsContext.tsx file in order to get the initailImageIndex to be loaded after loading an SR after disabling the prompts.
  • Added a null checking in WindowlevelActionMenu inorder to prevent the error displayd while loading the SR after disabling the prompts.

Testing

Initial image is correctly loaded now after disabling the prompt and loading the SR

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 18.19.0
  • Browser: Chrome

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for ohif-prod canceled.

Name Link
🔨 Latest commit 0fb3413
🔍 Latest deploy log https://app.netlify.com/sites/ohif-prod/deploys/67d3bd881a1c1c0008e78690

@ashik-trenser ashik-trenser force-pushed the fix/initial-image-index-for-sr-loading-without-prompt-3/9 branch from af42571 to 0fb3413 Compare March 14, 2025 05:24
@arul-trenser
Copy link
Contributor

@sedghi This PR is to cherry-pick changes from #4732 to 3.9. Could you please merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants