Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSD of epoched parcellated data incorrect #242

Closed
cgohil8 opened this issue Nov 23, 2023 · 0 comments · Fixed by #267
Closed

PSD of epoched parcellated data incorrect #242

cgohil8 opened this issue Nov 23, 2023 · 0 comments · Fixed by #267
Assignees
Labels
bug Something isn't working

Comments

@cgohil8
Copy link
Collaborator

cgohil8 commented Nov 23, 2023

We get weird spectra in the report when we calculate the PSD of epoched parcellated data here:

https://github.com/OHBA-analysis/osl/blob/main/osl/source_recon/parcellation/parcellation.py#L481

This is likely due to discontinuities between epochs. We should calculate the PSD of each epoch then average over epochs instead of concatenating across epochs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant