call cmd_owi from cmd_c directly instead of running a command, add all #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeom
reviewed
Jan 27, 2024
Merged
|
needs #134 to pass |
Merged
the cmd_owi cli parameters to cmd_c, use fpath
where possible, use Bos.OS.File instead of Stdlib.{open_in,open_out},
remove a weird Obj.magic
zapashcanon
force-pushed
the
cdmccmdowi
branch
from
29fa29b to
667ec2f
Compare
|
Merging as this is failing only because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cmd_owi cli parameters to cmd_c, use fpath
where possible, use Bos.OS.File instead of Stdlib.{open_in,open_out}, remove a weird Obj.magic
Should fix #129 cc @krtab.