Refactor module p #125
Merged
Refactor module p #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krtab
reviewed
Jan 23, 2024
src/symbolic.ml
Outdated
Comment on lines
12
to
14
| type 'a solver_module = (module Encoding.Solver_intf.S with type t = 'a) | ||
| type solver = S : 'a solver_module * 'a -> solver |
There was a problem hiding this comment.
This and
val solver: t -> solver
val pc: t -> Symbolic_value.S.vbool listwere added unsupervised by me and @epatrizio so you may want to use double the amount of caution when reviewing.
There was a problem hiding this comment.
I'm not sure this is what we want, but you'll find out while writing the fuzzer part. :-)
epatrizio
force-pushed
the
refactor_module_p
branch
from
4f68ee0 to
aa56715
Compare
epatrizio
force-pushed
the
refactor_module_p
branch
from
aa56715 to
32af069
Compare
|
The CI is failing. Can you run |
epatrizio
force-pushed
the
refactor_module_p
branch
from
32af069 to
0b4ef6c
Compare
krtab
approved these changes
Jan 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing work for fuzzing (done with @chambart)