Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] web_widget_x2many_2d_matrix: allow to set options and attrs for field value #3124

Merged

Conversation

DavidJForgeFlow
Copy link
Contributor

In previous versions, options were able to be set for the field value. Since migration to 17.0, this feature was no longer working. With this improvement, we can now set this attributes again.

For more example see OCA/manufacture#1443

@OCA-git-bot
Copy link
Contributor

Hi @JasminSForgeFlow,
some modules you are maintaining are being modified, check this out!

@DavidJForgeFlow DavidJForgeFlow force-pushed the 17.0-imp-web_widget_x2many_2d_matrix_options branch from 03173c4 to 3554b02 Compare March 14, 2025 14:25
@DavidJForgeFlow DavidJForgeFlow changed the title [IMP] web_widget_x2many_2d_matrix: allow to set options and attrs for field value [17.0][IMP] web_widget_x2many_2d_matrix: allow to set options and attrs for field value Mar 14, 2025
Copy link
Contributor

@JasminSForgeFlow JasminSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional + Code review 👍

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JasminSForgeFlow
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-3124-by-JasminSForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5ce0473 into OCA:17.0 Mar 18, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0d42432. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 17.0-imp-web_widget_x2many_2d_matrix_options branch March 18, 2025 07:46
@DavidJForgeFlow
Copy link
Contributor Author

Needs FP to 18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants