[18.0][MIG] web_dialog_size: Migration to 18.0 #3042
Conversation
New module that let the user expand a dialog box to the full screen width.
* [IMP] web_dialog_size: Put dialog size expanded by default * [REM] web_popup_large: By duplication of the functionality * [IMP] web_dialog_size: README and contributors * [ADD] configuration parameter for default behavior [FIX] return super's promise [IMP] use fontawesome icons for buttons
…efault_maximize parameter
* IMP: Added draggable support to dialogs * FIX: web_dialog_size: export modal - PR OCA#733 introduced draggable dialogs which broke some of them
- default_maximize option wasn't working due to strict value comparison
…#954) This addon had 2 problems after migrating to v11: 1. One call to backend's `ir.config_parameter.get_param` was done for each instantiated dialog, while the setting served for the whole session equally. 2. That model is now readable only by admin users, so non-admins couldn't use the default at all. Fixed now.
Checking result of rpc call, `dialog_maximize`, will end to be always `true` as the method will return a json: `{'dialog_maximize': false }`. So i changed the test to test the value of json key `dialog_maximize`
Includes some manual fixes to silent ESLint warnings.
It is important to let users decide their default dialog size. Some have ultrawide monitors and this module does more harm than benefit. Here I add such task to roadmap, to avoid forgetting about it. @Tecnativa
[IMP] web_dialog_size: Migration to 16.0 [REM] Remove duplicate configuration readme file [FIX] Make it work for normal dialogs also [FIX] SelectCreateDialog precommit
Currently translated at 100.0% (1 of 1 strings) Translation: web-16.0/web-16.0-web_dialog_size Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_dialog_size/it/
jeromeguerriat-msf
force-pushed
the
18.0-mig-web_dialog_size
branch
from
7402b6e to
e44d611
Compare
pedrobaeza
changed the title
|
/ocabot migration web_dialog_size |
jeromeguerriat-msf
force-pushed
the
18.0-mig-web_dialog_size
branch
from
e44d611 to
508104f
Compare
|
FYI, if you install this module with website_sale module, go to product form, Add Media in the Sales tab, upload and select a image for the product, save the product (manually). Open the uploaded image, there exist two expand icon. So do we have to accept the two almost identical buttons in that corner? |
|
Personal suggestion, since changing core is hard. |
|
@chienandalu I see that requested changes are done. Could you approve ? Thanks for all |
|
@bealdav Sure. non-blocking since it's only cosmetic. |
There was a problem hiding this comment.
Good catch @youring !
IMO this is far from a corner case, as it's used in x2ManyX2ManyFieldDialog and FormViewDialog with the limitations described in the commit (an with a different behavior from the one in this module).
It's not just cosmetic as the result is a missleading UI where the user can't know which button does what...
For me the changes should be made (and they're really trivial)
|
Ok I hope @jeromeguerriat-msf will answer |
jeromeguerriat-msf
force-pushed
the
18.0-mig-web_dialog_size
branch
from
508104f to
4403ef9
Compare
|
@bealdav i just pushed the suggestion ;) |
|
@jeromeguerriat-msf thanks a lot cc @chienandalu |
|
I think it is ready to be merged 😄 Thanks /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 7e66409. Thanks a lot for contributing to OCA. ❤️ |
re-ordered import to avoid "expected multiple syntax before single syntax" error for eslint
removed useless odoo-module in js file
changed the version
removed undefined "stop" parameter in if()