[17.0][MIG] sale_rental #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace openerp by odoo in import declarations
Convert readme to new subdir format
the creation of the stock location for rental respects the translations
Currently translated at 85.4% (88 of 103 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/
Currently translated at 9.7% (10 of 103 strings) Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_rental/
No more need to add users to the packaging group View of rental group is now possible on product.template form view
Standard migration + add some tests
Standard migration + add some tests
Currently translated at 40.7% (42 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/
Currently translated at 63.1% (65 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/
Currently translated at 49.5% (51 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr/
|
/ocabot migration sale_rental |
remi-filament
suggested changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks @edescalona for porting this module.
I discovered it with your PR, it seems to be working fine.
However, display on products and sale order could be improved !
| <field name="inherit_id" ref="product.product_normal_form_view" /> | ||
| <field name="arch" type="xml"> | ||
| <group name="sale" position="after"> | ||
| <group name="rental" string="Rental" invisible="type != 'service'"> |
There was a problem hiding this comment.
Suggested change
| <group name="rental" string="Rental" invisible="type != 'service'"> | |
| <group name="rental" string="Rental" invisible="detailed_type != 'service'"> |
You should use the new field detailed_type here I suppose since type is computed from this new field.
Comment on lines
+45
to
+71
| <group name="sale" position="inside"> | ||
| <label | ||
| for="rented_product_tmpl_id" | ||
| string="Rental" | ||
| invisible="type != 'service' or product_variant_count > 1" | ||
| /> | ||
| <field | ||
| name="rented_product_tmpl_id" | ||
| invisible="type != 'service' or product_variant_count > 1" | ||
| /> | ||
| <label | ||
| for="rental_service_tmpl_ids" | ||
| string="Rental Services" | ||
| invisible="type == 'service' or product_variant_count > 1" | ||
| /> | ||
| <field | ||
| name="rental_service_tmpl_ids" | ||
| nolabel="1" | ||
| invisible="rental_service_tmpl_ids == []" | ||
| /> | ||
| <button | ||
| type="action" | ||
| name="%(sale_rental.create_rental_product_action)d" | ||
| string="Create Rental Service" | ||
| invisible="type == 'service' or product_variant_count > 1" | ||
| /> | ||
| </group> |
There was a problem hiding this comment.
The view is not so visible, I would suggest the following instead:
Suggested change
| <group name="sale" position="inside"> | |
| <label | |
| for="rented_product_tmpl_id" | |
| string="Rental" | |
| invisible="type != 'service' or product_variant_count > 1" | |
| /> | |
| <field | |
| name="rented_product_tmpl_id" | |
| invisible="type != 'service' or product_variant_count > 1" | |
| /> | |
| <label | |
| for="rental_service_tmpl_ids" | |
| string="Rental Services" | |
| invisible="type == 'service' or product_variant_count > 1" | |
| /> | |
| <field | |
| name="rental_service_tmpl_ids" | |
| nolabel="1" | |
| invisible="rental_service_tmpl_ids == []" | |
| /> | |
| <button | |
| type="action" | |
| name="%(sale_rental.create_rental_product_action)d" | |
| string="Create Rental Service" | |
| invisible="type == 'service' or product_variant_count > 1" | |
| /> | |
| </group> | |
| <page name="sales" position="after"> | |
| <page name="rental" string="Rental" invisible="not sale_ok and detailed_type=='service'"> | |
| <group> | |
| <group name="rental-service" invisible="detailed_type != 'service' or product_variant_count > 1"> | |
| <field name="rented_product_tmpl_id" /> | |
| </group> | |
| <group name="rental-product" string="Rental Services" col="1" colspan="3" | |
| invisible="detailed_type == 'service' or product_variant_count > 1"> | |
| <field | |
| nolabel="1" | |
| name="rental_service_tmpl_ids" | |
| invisible="not rental_service_tmpl_ids" | |
| > | |
| <tree create="0" delete="0"> | |
| <field name="name" /> | |
| <field name="list_price" string="Rental Price per Day"/> | |
| </tree> | |
| </field> | |
| <button | |
| type="action" | |
| name="%(sale_rental.create_rental_product_action)d" | |
| string="Create Rental Service" | |
| colspan="3" | |
| /> | |
| </group> | |
| </group> | |
| </page> | |
| </page> |
| id="sale_rental_menu" | ||
| parent="sale.sale_order_menu" | ||
| action="sale_rental_action" | ||
| sequence="2" |
There was a problem hiding this comment.
Suggested change
| sequence="2" | |
| sequence="25" |
The menu is shown as first on sale which does not seem relevant, better to have it later in the menu list.
Hi @remi-filament thank you for your comments, I will review them and comment on them, greetings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BinhexTeam
For the migration of this module sale_rental use PR #46 as a base