[16.0][MIG] mass_mailing_custom_unsubscribe: Migration to 16.0 #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption (OCA#58) * [8.0][IMP][mass_mailing_custom_unsubscribe] Get reasons for unsubscription.
- Imported last updates from v8. - Adapted to v9. - Added a saner default to `mass_mailing.salt` configuration parameter by reusing `database.secret` if available, hoping that some day odoo/odoo#12040 gets merged. - Updated README. - Increase security, drop backwards compatibility. Security got improved upstream, which would again break compatibility among current addon and future master upstream. I choose to break it now and keep it secured future-wise, so I drop the backwards compatibility features. - Includes tour tests. - Removes outdated tests. - Extends the mailing list management form when unsubscriber is a contact. - Adds a reason form even if he is not. - Avoids all methods that were not model-agnostic. [FIX][mass_mailing_custom_unsubscribe] Reasons noupdate After this fix, when you update the addon, you will not lose your customized reasons. [FIX] Compatibilize with mass_mailing_partner Current test code was based on the assumption that the `@api.model` decorator on `create()` ensured an empty recordset when running the method, but that's not true. This was causing an incompatibility betwee these tests and the `mass_mailing_partner` addon, which works assuming 0-1 recordsets. Now records are created from an empty recordset, and thus tests work everywhere. Update instructions If the user does not add the unsubscribe snippet, nothing will happen, so it's added to README to avoid confusion when testing/using the addon. [FIX] Use the right operator to preserve recordsets order Using `|=` sorts records at will each time (treating them as Python's `set`). Using `+=` always appends a record to the end of the set. Since we are using the record position in the set, this caused the test to work sometimes and fail other times. Now it works always.
* [IMP] mass_mailing_custom_unsubscribe: GDPR compliance - Record resubscriptions too. - Record action metadata. - Make ESLint happy. - Quick color-based action distinction in tree view. - Add useful quick groupings. - Display (un)subscription metadata. - Pivot & graph views.
This creates inconsistency issues when assembling them in the README.
Currently translated at 80.0% (44 of 55 strings) Translation: social-11.0/social-11.0-mass_mailing_custom_unsubscribe Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mass_mailing_custom_unsubscribe/fr/
Fix assertIn error thrown in testing mode
Currently translated at 38.8% (33 of 85 strings) Translation: social-12.0/social-12.0-mass_mailing_custom_unsubscribe Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mass_mailing_custom_unsubscribe/sl/
…cretely from an event This addon extends the unsubscription process for allowing to unsubscribe only for an event. Standard process includes the mail in the general blacklist instead, which can be very unconvenient. This includes also the needed changes in the base module `mass_mailing_custom_unsubscribe`.
…out` So we need to explicitly opt-out (XD) that model from the new alternative mechanism for unsubscribing records.
Otherwise only admins can put notes
As the mail contacts model is renamed, we need to update the Reference field data with it. TT30414
FernandoRomera
force-pushed
the
16.0-mig-mass_mailing_custom_unsubscribe
branch
from
55ce947 to
5be1857
Compare
FernandoRomera
force-pushed
the
16.0-mig-mass_mailing_custom_unsubscribe
branch
2 times, most recently
from
dd436ff to
321d27f
Compare
FernandoRomera
force-pushed
the
16.0-mig-mass_mailing_custom_unsubscribe
branch
from
321d27f to
5dfb08e
Compare
hieulucky111
suggested changes
Jan 13, 2023
| "mass_mailing_id": mailing_id, | ||
| "unsubscriber_id": "%s,%d" % (model_name, res_id), | ||
| "action": "blacklist_rm", | ||
| } |
There was a problem hiding this comment.
i see this code is duplicated with what has be done in _add function. Could we have a generic function to do that?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
SiesslPhillip
pushed a commit
to grueneerde/OCA-social
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/social (16.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.