[FIX] sentry: Fix deprecated usage of text_type #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnavarro-kernet
force-pushed
the
patch-1
branch
from
acb93fc to
0724135
Compare
|
@hnavarro-kernet could you rebase? |
hnavarro-kernet
force-pushed
the
patch-1
branch
from
0724135 to
039727d
Compare
|
Should be rebased now @MiquelRForgeFlow |
|
Run pre-commit. |
hnavarro-kernet
force-pushed
the
patch-1
branch
from
039727d to
359295b
Compare
|
Sorry! Pre-commit successful, waiting for |
MiquelRForgeFlow
approved these changes
Feb 3, 2025
hnavarro-kernet
force-pushed
the
patch-1
branch
from
359295b to
d8b8f65
Compare
See original migration for reference: getsentry/sentry-python@2d354c7
hnavarro-kernet
force-pushed
the
patch-1
branch
from
d8b8f65 to
693de61
Compare
|
All 4 PRs depend on each other I guess:
So maybe merge them into one? Maybe backport from this one that should have fixed all the issues? If a maintainer with approval rights want to tell me what to do I'd be happy to, if not, this has been on prod since the PR was opened so I'm not going to fight the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See original migration for reference: getsentry/sentry-python@2d354c7