Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] auth_saml_environment: removes readonly attributes to allow provider creation #177

Closed
wants to merge 1 commit into from
Closed

[15.0] auth_saml_environment: removes readonly attributes to allow provider creation #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions auth_saml_environment/models/auth_saml_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ class AuthSamlProvider(models.Model):
_name = "auth.saml.provider"
_inherit = ["auth.saml.provider", "server.env.mixin"]

# Mandatory to be able to create objects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Mandatory to be able to create objects
# Non-mandatory to be able to create objects

idp_metadata = fields.Text(required=False)
sp_pem_public = fields.Char(required=False)
sp_pem_private = fields.Char(required=False)

sp_pem_public_path = fields.Char(
string="sp_pem_public_path env config value",
)
Expand Down
Loading