-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] auth_sms #724
Open
NL66278
wants to merge
7
commits into
OCA:16.0
Choose a base branch
from
Therp:16.0-mig-auth_sms
base: 16.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ocabot migration auth_sms |
c1b5cd3
to
4b09219
Compare
9aa4f28
to
cdfcc8f
Compare
67565e8
to
4c73ed8
Compare
I had to make one correction in another module as this had a problem in the login template that was inherited in the enter sms code template: https://github.com/OCA/server-auth/pull/724/files#diff-564288b4f2312458e84b608a19806e84706dcd2f700bc83bf4b3763b68881786 |
Also take care of compatibility with auth_oauth.
4c73ed8
to
89c5a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect logins by the user having to also enter a code sent through sms.
At the moment hardcoded to use the Messagebird provider.