[FIX] sale_product_pack: adjust discount formula for detailed packs #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @victoralmau, |
lef-adhoc
force-pushed
the
18.0-h-86712-lef
branch
4 times, most recently
from
14d15c1 to
bf866f3
Compare
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-product-pack
that referenced
this pull request
Jan 30, 2025
…scount. (OCA#197) Formerly was only taking into account the product packs discount, now take into account both discounts. Also we simplify the way that get_sale_order_line_vals works and now is simplier and use Odoo's onchange methods to compute the lines values. [FIX] product_pack: Pack component now have the tax of the company (OCA#198) Before this fix the product's packs new sale order line have multiple taxes: one por each company. Actually only need to add the taxes realated to the sale order's company. [FIX] product_pack: compute proper components prices (OCA#199) In some cases the values were prefetched and it was throwing bad prices. we add prefetch_fields to the context of the packs and that solve it. [FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (OCA#201) * [FIX] product_pack: Do not reset packs components when confirm sale order. If a sale order is updated from the website whrn confirm the order we do not expand the pack, we usit as it is. * [ADD] product_pack: Allow modify pack from backend/website Now we can choose if the product can be modified in the only int he backend or if can be modified also in the frontend by the customers. * [FIX] lint
lef-adhoc
force-pushed
the
18.0-h-86712-lef
branch
4 times, most recently
from
ead3758 to
d625a76
Compare
The discount formula for detailed packs has been updated to address inconsistencies when pricelists explicitly display discounts. The new formula ensures accurate representation of the combined discount by correctly factoring in both the parent pack and component discounts. Example: Parent pack discount: 5% Component A discount: 10% Component B discount: 20% The issue occurred when pricelists explicitly displayed discounts. For example, when the pricelist showed the discount percentage but did not properly calculate the combined effect of the pack discount and the component discounts, the displayed total was inconsistent. With the new formula: Component A effective discount: 100.0 - ((100.0 - 5.0) * (100.0 - 10.0) / 100.0) = 14.5% Component B effective discount: 100.0 - ((100.0 - 5.0) * (100.0 - 20.0) / 100.0) = 24.0% This ensures that when pricelists explicitly show discounts, the displayed percentage matches the calculated prices.
lef-adhoc
force-pushed
the
18.0-h-86712-lef
branch
from
d625a76 to
0f52bd0
Compare
lav-adhoc
approved these changes
Jan 30, 2025
|
@pedrobaeza Is it ready to merge? |
pedrobaeza
approved these changes
Jan 31, 2025
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at d0dbb11. Thanks a lot for contributing to OCA. ❤️ |
celm1990
pushed a commit
to Spearhead-Odoo/product-pack
that referenced
this pull request
Feb 4, 2025
…scount. (OCA#197) Formerly was only taking into account the product packs discount, now take into account both discounts. Also we simplify the way that get_sale_order_line_vals works and now is simplier and use Odoo's onchange methods to compute the lines values. [FIX] product_pack: Pack component now have the tax of the company (OCA#198) Before this fix the product's packs new sale order line have multiple taxes: one por each company. Actually only need to add the taxes realated to the sale order's company. [FIX] product_pack: compute proper components prices (OCA#199) In some cases the values were prefetched and it was throwing bad prices. we add prefetch_fields to the context of the packs and that solve it. [FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (OCA#201) * [FIX] product_pack: Do not reset packs components when confirm sale order. If a sale order is updated from the website whrn confirm the order we do not expand the pack, we usit as it is. * [ADD] product_pack: Allow modify pack from backend/website Now we can choose if the product can be modified in the only int he backend or if can be modified also in the frontend by the customers. * [FIX] lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discount formula for detailed packs has been updated to address inconsistencies when pricelists explicitly display discounts.
The new formula ensures accurate representation of the combined discount by correctly factoring in both the parent pack and component discounts.
Example:
Parent pack discount: 5%
Component A discount: 10%
Component B discount: 20%
The issue occurred when pricelists explicitly displayed discounts. For example, when the pricelist showed the discount percentage but did not properly calculate the combined effect of the pack discount and the component discounts, the displayed total was inconsistent.
With the new formula:
Component A effective discount:
100.0 - ((100.0 - 5.0) * (100.0 - 10.0) / 100.0) = 14.5%
Component B effective discount:
100.0 - ((100.0 - 5.0) * (100.0 - 20.0) / 100.0) = 24.0%