-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] sale_product_pack: Migration to 18 #190
Conversation
[ADD] icon.png
add a Roadmap section to the readme for creating sale_stock_product_pack
If not done this way, we can experiment ORM problems with cache misses.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/
…ame place Previous technique was trying to access `pack_parent_line_id` related values that are not set due to the mangling on virtual records/creation phase, provoking an ORM error, but there's no need of such complex code, as we only need to set price_unit to 0 when preparing vals without the need of overriding other methods.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/
Translated using Weblate (Spanish) Currently translated at 86.7% (13 of 15 strings) Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/es/
[UPD] Update sale_product_pack.pot sale_product_pack 12.0.1.0.2 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/
It's helpfull to know directly if the sale order line is editable. If the sale order is edited from an api, onchange are not always triggered so having this field helps to raise an error. And it can be used to display in the view that the line is not editable.
[UPD] README.rst sale_product_pack 12.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-12.0/product-pack-12.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-sale_product_pack/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-13.0/product-pack-13.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-sale_product_pack/
Currently translated at 42.1% (8 of 19 strings) Translation: product-pack-13.0/product-pack-13.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-sale_product_pack/nl/
Compatibility module between sale_product_pack and website_sale TT30385
…onsistent prices in some cases. TT32539
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-pack-17.0/product-pack-17.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-17-0/product-pack-17-0-sale_product_pack/
Currently translated at 100.0% (21 of 21 strings) Translation: product-pack-17.0/product-pack-17.0-sale_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-17-0/product-pack-17-0-sale_product_pack/it/
/ocabot migration sale_product_pack |
1749305
to
a1f8c02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @pedrobaeza |
a08b8df
to
727dce8
Compare
727dce8
to
10c85f2
Compare
@marielejeune Fixed the error with the Locked button. |
10c85f2
to
ce9ba34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pedrobaeza Hi! Everything seems ok. Could we merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at a8ea878. Thanks a lot for contributing to OCA. ❤️ |
No description provided.