Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_product_pack: Migration to 17.0 #188

Merged
merged 31 commits into from
Jan 2, 2025

Conversation

natuan9
Copy link

@natuan9 natuan9 commented Oct 30, 2024

ernestotejeda and others added 29 commits May 24, 2024 13:39
Currently translated at 100.0% (1 of 1 strings)

Translation: product-pack-12.0/product-pack-12.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-stock_product_pack/pt/
Currently translated at 100.0% (1 of 1 strings)

Translation: product-pack-12.0/product-pack-12.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-12-0/product-pack-12-0-stock_product_pack/fr/
…ines.

It seems to me that it would be if a user has the maximum stock permission, can edit the lines of packs, as well as a maximum sales permission.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-pack-13.0/product-pack-13.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-13-0/product-pack-13-0-stock_product_pack/
In v13 Odoo sets the stock at zero for products that are not services.
This commit will keep the stock of the services if they are packs,
to remain the functionality of the lasts versions.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-pack-16.0/product-pack-16.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/
Currently translated at 100.0% (5 of 5 strings)

Translation: product-pack-16.0/product-pack-16.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/es/
Currently translated at 100.0% (5 of 5 strings)

Translation: product-pack-16.0/product-pack-16.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/it/
Currently translated at 100.0% (5 of 5 strings)

Translation: product-pack-16.0/product-pack-16.0-stock_product_pack
Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-stock_product_pack/it/
@ALopez-Adhoc
Copy link

@pedrobaeza Hi! This pr is ready to be merged. It already has been reviewed and approved.

@pedrobaeza
Copy link
Member

/ocabot migration stock_product_pack

It requires an approval from a PSC.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 25, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 25, 2024
5 tasks
@natuan9 natuan9 force-pushed the 17.0-mig-stock_product_pack branch 2 times, most recently from 01eaa4c to 9bd6de0 Compare November 27, 2024 10:52
Copy link

@nicolascol nicolascol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natuan9 natuan9 requested a review from rousseldenis December 4, 2024 02:38
@augusto-weiss
Copy link

Hi @natuan9 could you include this fix: #184 ?? Thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

"pack_line_ids.product_id.stock_move_ids.quantity",
)
@api.depends_context(
"lot_id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add fields that are in base module. ORM will concatenate them

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Could you please help to review it again?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natuan9 natuan9 force-pushed the 17.0-mig-stock_product_pack branch from 9bd6de0 to b3ed252 Compare December 10, 2024 09:55
@natuan9
Copy link
Author

natuan9 commented Dec 10, 2024

Hi @natuan9 could you include this fix: #184 ?? Thanks

Hi @augusto-weiss I included your commit

@nicolascol
Copy link

Hi @pedrobaeza !
Could you merge?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-188-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8b28894 into OCA:17.0 Jan 2, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f9ddffb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.