-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][ADD] pos_loyalty_card_fixed_expiration_date: New module pos_loyalty_card_fixed_expiration_date #1287
Closed
BernatObrador
wants to merge
1
commit into
OCA:17.0
from
APSL:17.0-add-pos_loyalty_card_fixed_expiration_date
+750
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
====================================== | ||
Pos Loyalty Card Fixed Expiration Date | ||
====================================== | ||
|
||
.. | ||
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
!! This file is generated by oca-gen-addon-readme !! | ||
!! changes will be overwritten. !! | ||
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
!! source digest: sha256:df014b9d5a192e20df512ab00a40294a7e9f1c74e3bd171a5178e7a5c1dc321f | ||
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
||
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
:target: https://odoo-community.org/page/development-status | ||
:alt: Beta | ||
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
:alt: License: AGPL-3 | ||
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fpos-lightgray.png?logo=github | ||
:target: https://github.com/OCA/pos/tree/17.0/pos_loyalty_card_fixed_expiration_date | ||
:alt: OCA/pos | ||
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
:target: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_loyalty_card_fixed_expiration_date | ||
:alt: Translate me on Weblate | ||
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png | ||
:target: https://runboat.odoo-community.org/builds?repo=OCA/pos&target_branch=17.0 | ||
:alt: Try me on Runboat | ||
|
||
|badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
||
This module introduces the ability to set a fixed expiration date for | ||
gift cards. | ||
|
||
**Table of contents** | ||
|
||
.. contents:: | ||
:local: | ||
|
||
Usage | ||
===== | ||
|
||
Follow these steps to configure and use the module: | ||
|
||
1. Navigate to **Point of Sale -> Products -> Gift Cards & eWallet**. | ||
2. Create a new record and set the **Program Type** to **Gift Card**. | ||
3. Specify the **Duration Days**. | ||
4. Generate gift cards without setting an expiration date. | ||
|
||
- The generated gift cards will automatically have an expiration | ||
date set to **today's date + Duration Days**. | ||
|
||
5. If you manually set an expiration date, the system will use this | ||
specified date instead. | ||
|
||
Bug Tracker | ||
=========== | ||
|
||
Bugs are tracked on `GitHub Issues <https://github.com/OCA/pos/issues>`_. | ||
In case of trouble, please check there if your issue has already been reported. | ||
If you spotted it first, help us to smash it by providing a detailed and welcomed | ||
`feedback <https://github.com/OCA/pos/issues/new?body=module:%20pos_loyalty_card_fixed_expiration_date%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
||
Do not contact contributors directly about support or help with technical issues. | ||
|
||
Credits | ||
======= | ||
|
||
Authors | ||
------- | ||
|
||
* (APSL-Nagarro) | ||
|
||
Contributors | ||
------------ | ||
|
||
- [APSL-Nagarro](https://apsl.tech): | ||
|
||
- Antoni Marroig <amarroig@apsl.net> | ||
- Bernat Obrador <bobrador@apsl.net> | ||
|
||
Maintainers | ||
----------- | ||
|
||
This module is maintained by the OCA. | ||
|
||
.. image:: https://odoo-community.org/logo.png | ||
:alt: Odoo Community Association | ||
:target: https://odoo-community.org | ||
|
||
OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
mission is to support the collaborative development of Odoo features and | ||
promote its widespread use. | ||
|
||
.. |maintainer-peluko00| image:: https://github.com/peluko00.png?size=40px | ||
:target: https://github.com/peluko00 | ||
:alt: peluko00 | ||
.. |maintainer-bobrador| image:: https://github.com/bobrador.png?size=40px | ||
:target: https://github.com/bobrador | ||
:alt: bobrador | ||
|
||
Current `maintainers <https://odoo-community.org/page/maintainer-role>`__: | ||
|
||
|maintainer-peluko00| |maintainer-bobrador| | ||
|
||
This module is part of the `OCA/pos <https://github.com/OCA/pos/tree/17.0/pos_loyalty_card_fixed_expiration_date>`_ project on GitHub. | ||
|
||
You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
||
from . import models |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Copyright 2024 (APSL-Nagarro) - Antoni Marroig | ||
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
{ | ||
"name": "Pos Loyalty Card Fixed Expiration Date", | ||
"summary": "Set a fixed expiration date for loyalty cards", | ||
"version": "17.0.1.0.0", | ||
"category": "POS", | ||
"author": "(APSL-Nagarro), Odoo Community Association (OCA)", | ||
"maintainers": ["peluko00", "bobrador"], | ||
"website": "https://github.com/OCA/pos", | ||
"license": "AGPL-3", | ||
"application": False, | ||
"installable": True, | ||
"depends": [ | ||
"pos_sale", | ||
"loyalty", | ||
], | ||
"data": [ | ||
"views/loyalty_program_views.xml", | ||
], | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Translation of Odoo Server. | ||
# This file contains the translation of the following modules: | ||
# * pos_loyalty_card_fixed_expiration_date | ||
# | ||
msgid "" | ||
msgstr "" | ||
"Project-Id-Version: Odoo Server 17.0\n" | ||
"Report-Msgid-Bugs-To: \n" | ||
"POT-Creation-Date: 2025-01-17 09:12+0000\n" | ||
"PO-Revision-Date: 2025-01-17 09:12+0000\n" | ||
"Last-Translator: \n" | ||
"Language-Team: \n" | ||
"MIME-Version: 1.0\n" | ||
"Content-Type: text/plain; charset=UTF-8\n" | ||
"Content-Transfer-Encoding: \n" | ||
"Plural-Forms: \n" | ||
|
||
#. module: pos_loyalty_card_fixed_expiration_date | ||
#: model:ir.model.fields,field_description:pos_loyalty_card_fixed_expiration_date.field_loyalty_program__duration_days | ||
msgid "Duration Days" | ||
msgstr "Dies de durada" | ||
|
||
#. module: pos_loyalty_card_fixed_expiration_date | ||
#: model:ir.model,name:pos_loyalty_card_fixed_expiration_date.model_loyalty_card | ||
msgid "Loyalty Coupon" | ||
msgstr "Cupó lleial" | ||
|
||
#. module: pos_loyalty_card_fixed_expiration_date | ||
#: model:ir.model,name:pos_loyalty_card_fixed_expiration_date.model_loyalty_program | ||
msgid "Loyalty Program" | ||
msgstr "Programa de fidelitat " |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# Translation of Odoo Server. | ||
# This file contains the translation of the following modules: | ||
# * pos_loyalty_card_fixed_expiration_date | ||
# | ||
msgid "" | ||
msgstr "" | ||
"Project-Id-Version: Odoo Server 17.0\n" | ||
"Report-Msgid-Bugs-To: \n" | ||
"POT-Creation-Date: 2025-01-17 09:13+0000\n" | ||
"PO-Revision-Date: 2025-01-17 09:13+0000\n" | ||
"Last-Translator: \n" | ||
"Language-Team: \n" | ||
"MIME-Version: 1.0\n" | ||
"Content-Type: text/plain; charset=UTF-8\n" | ||
"Content-Transfer-Encoding: \n" | ||
"Plural-Forms: \n" | ||
|
||
#. module: pos_loyalty_card_fixed_expiration_date | ||
#: model:ir.model.fields,field_description:pos_loyalty_card_fixed_expiration_date.field_loyalty_program__duration_days | ||
msgid "Duration Days" | ||
msgstr "Días de duración" | ||
|
||
#. module: pos_loyalty_card_fixed_expiration_date | ||
#: model:ir.model,name:pos_loyalty_card_fixed_expiration_date.model_loyalty_card | ||
msgid "Loyalty Coupon" | ||
msgstr "Cupón de fidelidad" | ||
|
||
#. module: pos_loyalty_card_fixed_expiration_date | ||
#: model:ir.model,name:pos_loyalty_card_fixed_expiration_date.model_loyalty_program | ||
msgid "Loyalty Program" | ||
msgstr "Programa de fidelización" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
||
from . import loyalty_program | ||
from . import loyalty_card |
24 changes: 24 additions & 0 deletions
24
pos_loyalty_card_fixed_expiration_date/models/loyalty_card.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# Copyright 2024 (APSL-Nagarro) - Antoni Marroig | ||
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
||
from datetime import date, timedelta | ||
|
||
from odoo import api, models | ||
|
||
|
||
class LoyaltyCard(models.Model): | ||
_inherit = "loyalty.card" | ||
|
||
@api.model_create_multi | ||
def create(self, vals_list): | ||
res = super().create(vals_list) | ||
# If the expiration date is not set, we set it to | ||
# the current date + the fixed duration | ||
if vals_list: | ||
if not vals_list[0].get("expiration_date", False): | ||
for record in res: | ||
if record.program_id and record.program_id.duration_days > 0: | ||
res.expiration_date = date.today() + timedelta( | ||
days=res.program_id.duration_days | ||
) | ||
return res |
10 changes: 10 additions & 0 deletions
10
pos_loyalty_card_fixed_expiration_date/models/loyalty_program.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Copyright 2024 (APSL-Nagarro) - Antoni Marroig | ||
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
||
from odoo import fields, models | ||
|
||
|
||
class LoyaltyProgram(models.Model): | ||
_inherit = "loyalty.program" | ||
|
||
duration_days = fields.Integer() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[build-system] | ||
requires = ["whool"] | ||
build-backend = "whool.buildapi" |
3 changes: 3 additions & 0 deletions
3
pos_loyalty_card_fixed_expiration_date/readme/CONTRIBUTORS.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
- \[APSL-Nagarro\](<https://apsl.tech>): | ||
- Antoni Marroig \<<amarroig@apsl.net>\> | ||
- Bernat Obrador \<<bobrador@apsl.net>\> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
This module introduces the ability to set a fixed expiration date for gift cards. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Follow these steps to configure and use the module: | ||
|
||
1. Navigate to **Point of Sale -> Products -> Gift Cards & eWallet**. | ||
2. Create a new record and set the **Program Type** to **Gift Card**. | ||
3. Specify the **Duration Days**. | ||
4. Generate gift cards without setting an expiration date. | ||
- The generated gift cards will automatically have an expiration date set to **today's date + Duration Days**. | ||
5. If you manually set an expiration date, the system will use this specified date instead. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right.
vals_list
here can be a list containing completely different values. You shouldn't rely only on the first one, for all the records.Instead you can do something like this:
This works because create will return the records on the same order than the provided values that created them.
But moreover, I wonder if it wouldn't be a better idea to simply make the
expiration_date
a computed field withstore=True
,readonly=False
,precompute=True
, and@api.depends('program_id')
, instead of overridingcreate
.