Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] pos_partner_alternative_pricelist_load_background #1244

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

santostelmo
Copy link
Contributor

@santostelmo santostelmo commented Sep 25, 2024

Depends #1243

@santostelmo santostelmo marked this pull request as draft September 25, 2024 12:45
@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_alternative_pricelist_load_background branch 4 times, most recently from 70c4ca9 to f5fd741 Compare October 1, 2024 07:38
@santostelmo santostelmo marked this pull request as ready for review October 1, 2024 09:51
@santostelmo santostelmo force-pushed the 16.0-add-pos_partner_alternative_pricelist_load_background branch from f5fd741 to 6b53176 Compare January 28, 2025 10:15
Copy link

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall

pricelists = super().get_pos_ui_partner_pricelist_background(
pricelist_id, product_ids
)
# By design we do not calculate alternative prices on base pricelits

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a kw arg instead? It would be more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants