Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] pos_partner_birthdate #1104

Merged
merged 20 commits into from
Dec 18, 2023

Conversation

etobella
Copy link
Member

@etobella etobella commented Dec 4, 2023

Migration to 17.0

@cvinh

ecino and others added 19 commits December 4, 2023 11:52
Module for adding the birthdate in the customer screen of the POS.
Currently translated at 100.0% (2 of 2 strings)

Translation: pos-16.0/pos-16.0-pos_partner_birthdate
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_partner_birthdate/it/
Currently translated at 100.0% (2 of 2 strings)

Translation: pos-16.0/pos-16.0-pos_partner_birthdate
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_partner_birthdate/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-16.0/pos-16.0-pos_partner_birthdate
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_partner_birthdate/
@etobella
Copy link
Member Author

etobella commented Dec 4, 2023

/ocabot migration pos_partner_birthdate

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 4, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 27, 2023
31 tasks
Co-authored-by: rousemilano <routhberism@gmail.com>
@etobella etobella force-pushed the 17.0-mig-pos_partner_birthdate branch from 8fd605b to da6b956 Compare December 4, 2023 11:42
@cvinh
Copy link
Contributor

cvinh commented Dec 6, 2023

@etobella do you know why the birthdate field in the pos is not sensitive to language ? I tested it with a user having english language and the date format is jj/mm/aaaa
it should be mm/dd/yyyy
In the backend, I have mm/dd/yyyy
does it depends on my browser language (which is french) ?

@etobella
Copy link
Member Author

etobella commented Dec 7, 2023

@cvinh I followed the same logic we find in other date fields inside PoS.

https://github.com/odoo/odoo/blob/17.0/addons/point_of_sale/views/pos_ticket_view.xml#L160-L162

When I was checking it, I had similar issues, but at the end I choose to follow the same logic applied to other date fields.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella
Copy link
Member Author

/ocabot merge nobump

@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1104-by-ivantodorovich-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0c9405b into OCA:17.0 Dec 18, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b9e1429. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.