Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] pos_pricelist_show_discount: fix price with nested lists #1103

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

aleuffre
Copy link

@aleuffre aleuffre commented Dec 1, 2023

  • Add rounding to lst_price to avoid "0% discount" errors
  • Fix calculating lst_price when having pricelists that are calculated
    based on other pricelists.

@OCA-git-bot
Copy link
Contributor

Hi @renda-dev,
some modules you are maintaining are being modified, check this out!

* Add rounding to lst_price to avoid "0% discount" errors
* Fix calculating lst_price when having pricelists that are calculated
  based on other pricelists.
@aleuffre aleuffre force-pushed the 14.0-pos-pricelist-discount-fix branch from 4ecf378 to a94f04f Compare December 1, 2023 10:22
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@renda-dev renda-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1103-by-renda-dev-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eb3a987 into OCA:14.0 Dec 1, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f753d12. Thanks a lot for contributing to OCA. ❤️

@renda-dev renda-dev deleted the 14.0-pos-pricelist-discount-fix branch December 1, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants