Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] pos_partner_birthdate: Migration to 17.0 #1078

Closed

Conversation

rousemilano
Copy link

@pedrobaeza Buenas noches, por favor, quisiera el review tecnico, de este módulo que migre. Muchas gracias,

@legalsylvain
Copy link
Contributor

Hi @rousemilano. Thanks for your contribution.
At the first sight it looks like you didn't use correct git command to preserve git history. Could you take a look on that documentation ? https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

thanks !

@legalsylvain
Copy link
Contributor

/ocabot migration pos_partner_birthdate

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 8, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 8, 2023
31 tasks
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need this: #1072 (you can review the PR)

@rousemilano rousemilano changed the title [MIG] pos_partner_birthdate: Migration to 17.0 [17.0][MIG] pos_partner_birthdate: Migration to 17.0 Nov 8, 2023
@rousemilano
Copy link
Author

@chienandalu Hi, make other changes, but they need to enable the 17.0 branch to the "partner-contact" repository to be able to upload the missing module.

@chienandalu
Copy link
Member

But you didn't follow the migration guidelines. Simply follow the script in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

(you can save your module in another folder and paste it back after doing the initial migration tasks

@etobella
Copy link
Member

etobella commented Dec 3, 2023

@rousemilano will you follow @chienandalu comments?

@etobella
Copy link
Member

etobella commented Dec 4, 2023

Superseeded by #1104

@etobella etobella closed this Dec 4, 2023
@etobella
Copy link
Member

etobella commented Dec 4, 2023

It was working, but we needed to restore all the previous logic. Also, I made some changes to have the same approach we had on the current pos format. I will add yourself as co-author on my commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants